add sideEffects: false to package json in esm folder
#683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 351d1c4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@jeetiss is attempting to deploy a commit to the wagmi Team on Vercel. A member of the Team first needs to authorize it. |
fubhy
approved these changes
Jun 9, 2023
|
Thanks. You can also introduce the size-limit probes here imho. That way we can easily iterate on them in the follow-up with the annotations. |
|
Thanks @jeetiss! That's good to go as far as I'm concerned. I think we can add even more checks to the size-limit config later on for good measure but that can follow in another PR. LGTM! |
tmm
reviewed
Jun 9, 2023
tmm
reviewed
Jun 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is part of
PR-Codex overview
This PR focuses on optimizing the
viempackage by marking it as side effects free. Notable changes include:Detailed summary
viempackage marked as side effects freebuild:esmscript now includessideEffectsproperty inpackage.jsonsize-limitchecks forviem (cjs),viem (tree-shaking check), andviem/chainssimple-git-hooksconfiguration.