fix(tsconfig): explicit module constraints

[sambacha]

These options are viral: enabling them in a package requires all downstream consumers to enable them as well.

Consumers can now opt into these semantics, it also does not require them to do so. Consumers can always safely use alternative import syntaxes (including falling back to require() and import()), or can enable these flags and opt into this behavior themselves.

---

PR-Codex overview

This PR turns off esModuleInterop and allowSyntheticDefaultImports in the tsconfig file.

Detailed summary

• esModuleInterop and allowSyntheticDefaultImports are set to false in tsconfig.base.json.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[changeset-bot]

🦋 Changeset detected

Latest commit: 88658f2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

@sambacha is attempting to deploy a commit to the wagmi Team on Vercel.

A member of the Team first needs to authorize it.

[sambacha]

These options are viral: enabling them in a package requires all downstream consumers to enable them as well.

Consumers can now opt into these semantics, it also does not require them to do so. Consumers can always safely use alternative import syntaxes (including falling back to require() and import()), or can enable these flags and opt into this behavior themselves.

PR-Codex overview

This PR focuses on updating the tsconfig.base.json file by setting esModuleInterop and allowSyntheticDefaultImports to false, and enabling forceConsistentCasingInFileNames and verbatimModuleSyntax.

Detailed summary

• Set esModuleInterop to false
• Set allowSyntheticDefaultImports to false
• Enable forceConsistentCasingInFileNames
• Enable verbatimModuleSyntax

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

> * Enable `forceConsistentCasingInFileNames`
> * Enable `verbatimModuleSyntax`

This was not enabled, look at the diff.

[pr-codex]

{your question}`

> * Enable `forceConsistentCasingInFileNames`
> * Enable `verbatimModuleSyntax`

This was not enabled, look at the diff.

@sambacha My apologies. Here is the question:

What changes were made to the tsconfig.base.json file?

[fubhy]

Yeah this is good.

[fubhy]

Tried to do that with https://github.com/wagmi-dev/viem/pull/391/files but didn't realize that it's implicitly enabled due to NodeNext. Whoops.

[jxom]

enabling them in a package requires all downstream consumers to enable them as well.

does this mean this is a breaking change? 😅

[fubhy]

enabling them in a package requires all downstream consumers to enable them as well.

does this mean this is a breaking change? sweat_smile

Sam is disabling them here. Currently they are implicitly enabled. So as it stands, consumers are affected by it. Disabling it should not cause any breaking changes but simply be more lenient on consumers. But let's verify that.

[jxom]

Gotcha! I’m all good with it then!

[codecov]

Codecov Report

Merging #672 (0a4f8ad) into main (4346054) will decrease coverage by 9.92%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
- Coverage   99.86%   89.94%   -9.92%     
==========================================
  Files         260      250      -10     
  Lines       24709    24362     -347     
  Branches     2052     1406     -646     
==========================================
- Hits        24676    21913    -2763     
- Misses         31     2410    +2379     
- Partials        2       39      +37     

see 114 files with indirect coverage changes