Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync 7739 #3096

Merged
merged 1 commit into from
Dec 5, 2024
Merged

feat: sync 7739 #3096

merged 1 commit into from
Dec 5, 2024

Conversation

jxom
Copy link
Member

@jxom jxom commented Dec 5, 2024

Sync latest 7739 changes.

Ref: Vectorized/solady#1130, ethereum/ERCs#687

Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: 8c1764a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem 🔄 Building (Inspect) Visit Preview Dec 5, 2024 5:35am

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (2d03645) to head (8c1764a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3096   +/-   ##
=======================================
  Coverage   99.64%   99.65%           
=======================================
  Files         877      877           
  Lines       71243    71207   -36     
  Branches     3139     3139           
=======================================
- Hits        70990    70960   -30     
+ Misses        235      231    -4     
+ Partials       18       16    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
import * from 'viem' (esm) 62.88 KB (0%) 1.3 s (0%) 7.6 s (-54.01% 🔽) 8.8 s
const viem = require('viem') (cjs) 72.97 KB (0%) 1.5 s (0%) 10.1 s (-64.35% 🔽) 11.6 s
import { createClient, http } from 'viem' 6.33 KB (0%) 127 ms (0%) 620 ms (-52.47% 🔽) 746 ms
import * from 'viem/account-abstraction' 45.69 KB (-0.09% 🔽) 914 ms (-0.09% 🔽) 4.7 s (-64.1% 🔽) 5.7 s
import { toCoinbaseSmartAccount } from 'viem/account-abstraction' 35.66 KB (0%) 714 ms (0%) 6.1 s (+14.22% 🔺) 6.9 s
import * from 'viem/accounts' 82.37 KB (0%) 1.7 s (0%) 4.6 s (+74.25% 🔺) 6.2 s
import { privateKeyToAccount } from 'viem/accounts' 21.07 KB (0%) 422 ms (0%) 1.7 s (-36.26% 🔽) 2.2 s
import { mnemonicToAccount } from 'viem/accounts' 27.4 KB (0%) 549 ms (0%) 4.4 s (-11.27% 🔽) 4.9 s
import * from 'viem/actions' 47.99 KB (0%) 960 ms (0%) 6.9 s (-17.45% 🔽) 7.9 s
import { getBlockNumber } from 'viem/actions' 318 B (0%) 10 ms (0%) 32 ms (-10.45% 🔽) 42 ms
import * from 'viem/chains' 40.02 KB (0%) 801 ms (0%) 8 s (-18.71% 🔽) 8.8 s
import { mainnet } from 'viem/chains' 324 B (0%) 10 ms (0%) 29 ms (-95.81% 🔽) 39 ms
import * from 'viem/chains/utils' 1.08 KB (0%) 22 ms (0%) 54 ms (+11.77% 🔺) 76 ms
import * from 'viem/ens' 47.29 KB (0%) 946 ms (0%) 7.1 s (+80.19% 🔺) 8 s
import { getEnsAvatar } from 'viem/ens' 22.38 KB (0%) 448 ms (0%) 3.1 s (+21.83% 🔺) 3.6 s
import * from 'viem/siwe' 31.47 KB (0%) 630 ms (0%) 5.1 s (-31.94% 🔽) 5.8 s
import { verifySiweMessage } from 'viem/siwe' 30.38 KB (0%) 608 ms (0%) 6.7 s (-7.09% 🔽) 7.3 s

@jxom jxom merged commit 092615f into main Dec 5, 2024
32 of 34 checks passed
@jxom jxom deleted the jxom/up-7739 branch December 5, 2024 05:39
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
@tmm tmm mentioned this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant