-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: zero base fee #1280
fix: zero base fee #1280
Conversation
|
@holic is attempting to deploy a commit to the wagmi Team on Vercel. A member of the Team first needs to authorize it. |
f9e864b
to
fffe4f0
Compare
I think I found it. We had an I discovered this because I could change I'm still not sure why the |
e7ed2bd
to
d483631
Compare
I just bumped viem from 1.6.0 to 1.14.0 and I am seeing "intrinsic gas too high" when using
writeContract
on an anvil chain running with--base-fee 0
and viem chain set tofees: { defaultPriorityFee: 0n }
.Looking at request logs, I can see a new call to
eth_maxPriorityFeePerGas
beforeeth_estimateGas
that returns0x3b9aca00
, which is used as the value formaxFeePerGas
andmaxPriorityFeePerGas
in theeth_estimateGas
call.Before the version bump, there was no
eth_maxPriorityFeePerGas
call and the0n
from the chain config'sdefaultPriorityFee
was used as the value ofmaxFeePerGas
andmaxPriorityFeePerGas
.I am not sure if I am misunderstanding the new fee calculation but this seems like a regression from the previous behavior that respected the chain config's
defaultPriorityFee
? I think this behavior changed in #1058 but haven't read it thoroughly.I've added a test for this here, but can't seem to get tests running locally to verify that it fails + add a fix.
PR-Codex overview
Focus of the PR:
This PR focuses on improving the handling of defaultPriorityFee in the code.
Detailed summary: