feat: made salt mandatory on ERC-7739 verifierDomain

wevm · Dec 29, 2024 · 7148e47 · 7148e47
1 parent 368dac0
commit 7148e47
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 6 deletions.
diff --git a/.changeset/tame-shoes-brake.md b/.changeset/tame-shoes-brake.md
@@ -0,0 +1,5 @@
+---
+"viem": patch
+---
+
+**Experimental (ERC-7739):** Added `salt` as a mandatory field of `verifierDomain`.
diff --git a/site/pages/experimental/erc7739/hashTypedData.md b/site/pages/experimental/erc7739/hashTypedData.md
@@ -9,13 +9,13 @@ Hashes [EIP-712](https://eips.ethereum.org/EIPS/eip-712) typed data via [ERC-773
 ## Import
 
 ```ts
-import { hashTypedData } from 'viem/experimental/solady'
+import { hashTypedData } from 'viem/experimental/erc7739'
 ```
 
 ## Usage
 
 ```ts
-import { hashTypedData } from 'viem/experimental/solady'
+import { hashTypedData } from 'viem/experimental/erc7739'
 
 hashTypedData({
   domain: {
@@ -50,10 +50,11 @@ hashTypedData({
   extensions: [],
   fields: '0x0f',
   verifierDomain: {
+    chainId: 1,
     name: 'Smart Account',
+    salt: '0x0000000000000000000000000000000000000000000000000000000000000000',
     version: '1',
     verifyingContract: '0x1234567890abcdef1234567890abcdef12345678',
-    chainId: 1,
   },
 })
 ```

diff --git a/src/actions/public/getEip712Domain.ts b/src/actions/public/getEip712Domain.ts
@@ -22,7 +22,7 @@ export type GetEip712DomainParameters = {
 export type GetEip712DomainReturnType = {
   domain: RequiredBy<
     TypedDataDomain,
-    'chainId' | 'name' | 'verifyingContract' | 'version'
+    'chainId' | 'name' | 'verifyingContract' | 'salt' | 'version'
   >
   fields: Hex
   extensions: readonly bigint[]

diff --git a/src/experimental/erc7739/utils/hashTypedData.ts b/src/experimental/erc7739/utils/hashTypedData.ts
@@ -16,7 +16,7 @@ export type HashTypedDataParameters<
 > = TypedDataDefinition<typedData, primaryType, primaryTypes> & {
   verifierDomain: RequiredBy<
     TypedDataDomain,
-    'chainId' | 'name' | 'verifyingContract' | 'version'
+    'chainId' | 'name' | 'verifyingContract' | 'salt' | 'version'
   >
 }
 

diff --git a/src/package.json b/src/package.json
@@ -121,7 +121,7 @@
       "chains/utils": ["./_types/chains/utils.d.ts"],
       "ens": ["./_types/ens/index.d.ts"],
       "experimental": ["./_types/experimental/index.d.ts"],
-      "experimental/solady": ["./_types/experimental/solady/index.d.ts"],
+      "experimental/erc7739": ["./_types/experimental/erc7739/index.d.ts"],
       "node": ["./_types/node/index.d.ts"],
       "op-stack": ["./_types/op-stack/index.d.ts"],
       "siwe": ["./_types/siwe/index.d.ts"],