Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Typescript #10

Merged
merged 3 commits into from
Mar 4, 2024
Merged

feature: Typescript #10

merged 3 commits into from
Mar 4, 2024

Conversation

marlonmarcello
Copy link
Contributor

@marlonmarcello marlonmarcello commented Mar 1, 2024

Goal

To add types!

I also added a new hook useStickerbook that handles all the state and actions.
Should be a much nicer and simpler DX now.

Notes

I also made a few other improvements.

  1. We now have a single file output, with named exports, much nicer DX when using it
  2. We are using CSS modules! No more style leaking on embed websites. I also added data- attributes to the elements so it's easier to select when using it.

Still need to update the Docs!

Copy link

codesandbox bot commented Mar 1, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@marlonmarcello marlonmarcello changed the title feature: Vite + Typescript feature: Typescript Mar 1, 2024
@marlonmarcello marlonmarcello self-assigned this Mar 1, 2024
@marlonmarcello marlonmarcello added the enhancement New feature or request label Mar 1, 2024
@marlonmarcello marlonmarcello added this to the v4 milestone Mar 1, 2024
Copy link
Member

@liamegan liamegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too big for a proper review, but in general I think it looks great.

@marlonmarcello
Copy link
Contributor Author

Deploying it with a beta flag so we can do some integration testing.

@marlonmarcello marlonmarcello merged commit 2782bb9 into main Mar 4, 2024
@marlonmarcello marlonmarcello deleted the feature/typescript branch March 4, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants