Add readonly flag to fetch_reified_items method

[dmrAnderson]

No description provided.

[westonganger]

Suggested change

	assert children_hash.all? { |_k, v| v.all? { |x| x.readonly? } }
	assert children_hash.values.all?(&:readonly?)

[westonganger]

Suggested change

	assert children_hash.all? { |_k, v| v.all? { |x| x.readonly? } }
	assert children_hash.values.all?(&:readonly?)

[westonganger]

Can we use multiline if statement here. Thanks

if readonly
  reified_item.readonly!
end

[westonganger]

Looks like a good change. I've suggested a couple of comments

Also can we maybe update the section in the README

As a safety these records have the @readonly = true attribute set on them. If you want to perform any write actions on the returned instances you will have to set @readonly = nil.

reified_parent, reified_children_hash = snapshot.fetch_reified_items

reified_parent.instance_variable_set("@readonly", false)

to:

As a safety these records have the readonly attribute set on them. If you want to perform any write actions on the returned instances you will have to set the readonly attribute to false

reified_parent, reified_children_hash = snapshot.fetch_reified_items(readonly: false)
# OR
reified_parent, reified_children_hash = snapshot.fetch_reified_items
reified_children_hash.first.instance_variable_set("@readonly", false)

[westonganger]

Please merge the two codeblocks and move this inside the code block

[westonganger]

Merged thanks for your contribution!