This repository has been archived by the owner on Apr 10, 2024. It is now read-only.
[pandas 2.0] Re-factor of the DataType classes #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changing PrimitiveType to NumericType
* Removing the macro for declaring sub-types of NumericType and
instead using template arguments
* Addding a static SINGLETON member to the NumericType base class
instead of the macros for methods for creating singletons for
each numeric type
* Removing NullType's inheritance of PrimitiveType
* Removing intermediate base class between {Integer,Floating}ArrayImpl
and PrimitiveType and just making a concrete template based
class {Integer,Floating}Array
* Changing FLOAT and DOUBLE to FLOAT32 and FLOAT64
|
Cool, this looks good -- thanks for making the Cython code compile again! I wasn't aware of the trailing return type syntax in C++11, so that's super helpful. |
wesm
changed the title
wesm
pushed a commit
that referenced
this pull request
Oct 20, 2016
* Changing PrimitiveType to NumericType * Removing the macro for
declaring sub-types of NumericType and instead using template
arguments * Addding a static SINGLETON member to the NumericType base
class instead of the macros for methods for creating singletons for
each numeric type * Removing NullType's inheritance of PrimitiveType
* Removing intermediate base class between {Integer,Floating}ArrayImpl
and PrimitiveType and just making a concrete template based class
{Integer,Floating}Array * Changing FLOAT and DOUBLE to FLOAT32 and
FLOAT64
Author: Joshua Storck <[email protected]>
Closes #55 from joshuastorck/pandas-2.0 and squashes the following commits:
1614d44 [Joshua Storck] * Fixing native.p{xd,yx} so that it matches the latest C++ code * Changing PrimitiveType to NumericType * Removing the macro for declaring sub-types of NumericType and instead using template arguments * Addding a static SINGLETON member to the NumericType base class instead of the macros for methods for creating singletons for each numeric type * Removing NullType's inheritance of PrimitiveType * Removing intermediate base class between {Integer,Floating}ArrayImpl and PrimitiveType and just making a concrete template based class {Integer,Floating}Array * Changing FLOAT and DOUBLE to FLOAT32 and FLOAT64
wesm
pushed a commit
that referenced
this pull request
Dec 12, 2016
* Changing PrimitiveType to NumericType * Removing the macro for
declaring sub-types of NumericType and instead using template
arguments * Addding a static SINGLETON member to the NumericType base
class instead of the macros for methods for creating singletons for
each numeric type * Removing NullType's inheritance of PrimitiveType
* Removing intermediate base class between {Integer,Floating}ArrayImpl
and PrimitiveType and just making a concrete template based class
{Integer,Floating}Array * Changing FLOAT and DOUBLE to FLOAT32 and
FLOAT64
Author: Joshua Storck <[email protected]>
Closes #55 from joshuastorck/pandas-2.0 and squashes the following commits:
1614d44 [Joshua Storck] * Fixing native.p{xd,yx} so that it matches the latest C++ code * Changing PrimitiveType to NumericType * Removing the macro for declaring sub-types of NumericType and instead using template arguments * Addding a static SINGLETON member to the NumericType base class instead of the macros for methods for creating singletons for each numeric type * Removing NullType's inheritance of PrimitiveType * Removing intermediate base class between {Integer,Floating}ArrayImpl and PrimitiveType and just making a concrete template based class {Integer,Floating}Array * Changing FLOAT and DOUBLE to FLOAT32 and FLOAT64
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead using template arguments
instead of the macros for methods for creating singletons for
each numeric type
and PrimitiveType and just making a concrete template based
class {Integer,Floating}Array