Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Usage for stream pipeline of callback version #9455

Merged

Conversation

reiji-h
Copy link
Contributor

@reiji-h reiji-h commented Nov 29, 2024

Summary

  • promise 版ではない pipeline の使い方を修正
  • すべての pipeline を promise にしたり、eslint で import { pipeline } from 'stream' を禁止することはしていない

Task

https://redmine.weseek.co.jp/issues/158095

Note

  • promise 版と callback 版の違いは、Promise を返す Stream を受け取れるかどうか
  • 基本的には promise 版で問題ない
  • だが、pipeline 後の Stream を使用したい場合は、callback 版を用いる必要がある
    • その際、finished を使うことで Stream の完了待ちができる
  • callback 版では、最後の引数に関数が必要なので、今回は適当な関数を入れている。
  • 修正箇所の export 機能 import 機能等は試し、使えることを確認済み

Copy link

changeset-bot bot commented Nov 29, 2024

⚠️ No Changeset found

Latest commit: cfd4dbe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

mergify bot added a commit that referenced this pull request Dec 5, 2024
@mergify mergify bot merged commit 383b5fe into master Dec 5, 2024
30 checks passed
@mergify mergify bot deleted the imprv/158095-158175-pipeline-from-stream-is-required branch December 5, 2024 10:35
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
@yuki-takei yuki-takei changed the title imprv: fix pipeline of callback version fix: Usage for stream pipeline of callback version Dec 12, 2024
@github-actions github-actions bot mentioned this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants