Skip to content

Commit

Permalink
kvserver/rangefeed: metamorphically enable RangefeedUseBufferedSender
Browse files Browse the repository at this point in the history
This patch metamorphically enables the cluster setting
RangefeedUseBufferedSender.

Release note: none
Part of: cockroachdb#135332
  • Loading branch information
wenyihu6 committed Dec 12, 2024
1 parent 2926980 commit e273e83
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pkg/kv/kvserver/replica_rangefeed.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/util/hlc"
"github.com/cockroachdb/cockroach/pkg/util/limit"
"github.com/cockroachdb/cockroach/pkg/util/log"
"github.com/cockroachdb/cockroach/pkg/util/metamorphic"
"github.com/cockroachdb/cockroach/pkg/util/syncutil/singleflight"
"github.com/cockroachdb/cockroach/pkg/util/timeutil"
"github.com/cockroachdb/cockroach/pkg/util/uuid"
Expand Down Expand Up @@ -91,14 +92,13 @@ var ErrBufferedSenderNotSupported = unimplemented.NewWithIssue(

// RangefeedUseBufferedSender controls whether rangefeed uses a node level
// buffered sender to buffer events instead of buffering events separately in a
// channel at a per client per registration level. It is currently left
// unimplemented and disabled everywhere (#126560).
// channel at a per client per registration level.
var RangefeedUseBufferedSender = settings.RegisterBoolSetting(
settings.SystemOnly,
"kv.rangefeed.buffered_sender.enabled",
"use buffered sender for all range feeds instead of buffering events "+
"separately per client per range",
false,
metamorphic.ConstantWithTestBool("kv.rangefeed.buffered_sender.enabled", false),
settings.WithValidateBool(func(_ *settings.Values, b bool) error {
if buildutil.CrdbTestBuild || !b {
return nil
Expand Down

0 comments on commit e273e83

Please sign in to comment.