Skip to content

Commit

Permalink
roachtest: run Read Committed variants of TPC-C without txn retry loops
Browse files Browse the repository at this point in the history
Closes cockroachdb#115191.
Depends on cockroachdb#61986.

This commit switches the two nightly Read Committed variants of the TPC-C
roachtest to run without transaction retry loops, using the `--txn-retries` flag
introduced in cockroachdb#117096. With cockroachdb#117630 and cockroachdb#61986 resolved (the latter of which
is still in review and under development), these tests both pass.

Release note: None
  • Loading branch information
nvanbenschoten authored and wenyihu6 committed Feb 21, 2024
1 parent e6aff2b commit b6a7486
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/cmd/roachtest/tests/tpcc.go
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ func registerTPCC(r registry.Registry) {
t.L().Printf("computed headroom warehouses of %d\n", headroomWarehouses)
runTPCC(ctx, t, c, tpccOptions{
Warehouses: headroomWarehouses,
ExtraRunArgs: "--isolation-level=read_committed",
ExtraRunArgs: "--isolation-level=read_committed --txn-retries=false",
Duration: 120 * time.Minute,
SetupType: usingImport,
})
Expand Down Expand Up @@ -572,7 +572,7 @@ func registerTPCC(r registry.Registry) {
runTPCC(ctx, t, c, tpccOptions{
Warehouses: 1,
Duration: 10 * time.Minute,
ExtraRunArgs: "--wait=false --isolation-level=read_committed",
ExtraRunArgs: "--wait=false --isolation-level=read_committed --txn-retries=false",
SetupType: usingImport,
ExpensiveChecks: true,
})
Expand Down

0 comments on commit b6a7486

Please sign in to comment.