Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEXUS-2423] - Remove Bothub at new projects #946

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

Aldemylla
Copy link
Collaborator

@Aldemylla Aldemylla commented Jan 7, 2025

Description

Type of Change

    • Bugfix
    • Feature
    • Code style update (formatting, local variables)
    • Refactoring (no functional changes, no api changes)
    • Tests
    • Other

Motivation and Context

To encourage users to use only the agent builder, we decided to remove the bothub module for projects created in 2025 onwards.

Summary of Changes

  • Added validation to remove bothub at new projects;
  • Added a enviroment variable to allow some projects to use bothub.

Demonstration

image

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.83%. Comparing base (006928e) to head (c93c65a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #946      +/-   ##
==========================================
+ Coverage   31.79%   31.83%   +0.03%     
==========================================
  Files         175      175              
  Lines       20397    20407      +10     
  Branches      549      553       +4     
==========================================
+ Hits         6486     6496      +10     
  Misses      13911    13911              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Aldemylla Aldemylla marked this pull request as ready for review January 7, 2025 21:20
@Aldemylla Aldemylla merged commit 9edfe8b into main Jan 8, 2025
2 checks passed
@Aldemylla Aldemylla deleted the feature/remove-bothub-new-projects branch January 8, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants