Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENGAGE-2378] - Configure logic to separate weni framework and opinionated #943

Open
wants to merge 18 commits into
base: feature/new-platform-1.5
Choose a base branch
from

Conversation

MarcusviniciusLsantos
Copy link
Contributor

Description

Type of Change

    • Bugfix
    • Feature
    • Code style update (formatting, local variables)
    • Refactoring (no functional changes, no api changes)
    • Tests
    • Other

Motivation and Context

  • new logic for platform 1.5

Summary of Changes

  • add short options
  • add constants to helper project_type logic

Design Files

Demonstration

image

@MarcusviniciusLsantos MarcusviniciusLsantos changed the base branch from main to feature/module-federation-with-rspack January 3, 2025 13:50
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 31.83%. Comparing base (988dd0a) to head (0493419).

Files with missing lines Patch % Lines
src/components/Sidebar/Sidebar.vue 94.59% 2 Missing ⚠️
Additional details and impacted files
@@                            Coverage Diff                            @@
##           feature/module-federation-with-rspack     #943      +/-   ##
=========================================================================
+ Coverage                                  31.25%   31.83%   +0.58%     
=========================================================================
  Files                                        176      177       +1     
  Lines                                      20103    20261     +158     
  Branches                                     548      611      +63     
=========================================================================
+ Hits                                        6284     6451     +167     
+ Misses                                     13819    13810       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcusviniciusLsantos MarcusviniciusLsantos changed the title [ENGAGE-2378] - Configure logic to separate weni framework and opinionado [ENGAGE-2378] - Configure logic to separate weni framework and opinionated Jan 3, 2025
@MarcusviniciusLsantos MarcusviniciusLsantos changed the base branch from feature/module-federation-with-rspack to feature/new-platform-1.5 January 3, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants