Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENGAGE-2399] - Fix project options not close dropdown on click iframes #941

Merged

Conversation

mateuseduardomedeiros
Copy link
Contributor

Description

Type of Change

    • Bugfix
    • Feature
    • Code style update (formatting, local variables)
    • Refactoring (no functional changes, no api changes)
    • Tests
    • Other

Motivation and Context

The project dropdown must be closed when clicking outside its context and this does not happen when clicking on iframes, making usability poor

Summary of Changes

  • Fix project options not close dropdown on click iframes

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.79%. Comparing base (5055220) to head (4b853d8).

Files with missing lines Patch % Lines
src/components/Sidebar/SidebarOption.vue 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #941      +/-   ##
==========================================
+ Coverage   31.75%   31.79%   +0.04%     
==========================================
  Files         175      175              
  Lines       20383    20397      +14     
  Branches      549      549              
==========================================
+ Hits         6473     6486      +13     
- Misses      13910    13911       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mateuseduardomedeiros mateuseduardomedeiros merged commit 006928e into main Jan 2, 2025
2 checks passed
mateuseduardomedeiros added a commit that referenced this pull request Jan 2, 2025
…-click-iframes

[ENGAGE-2399] - Fix project options not close dropdown on click iframes
@mateuseduardomedeiros mateuseduardomedeiros deleted the hotfix/close-project-dropdown-on-click-iframes branch January 2, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants