Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep for some days the old CSS and remove GET method support #935

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

baltazarweni
Copy link

Description

Keep for some days the old CSS and remove GET method support

Type of Change

    • Bugfix
    • Feature
    • Code style update (formatting, local variables)
    • Refactoring (no functional changes, no api changes)
    • Tests
    • Other

Motivation and Context

Add script in posix shell to remove old files and use in Dockerfile and disable GET method

Summary of Changes

Implementation of a posix shell script to manage and remove old files based on unix timestamps since the base image only provides posix shell. The script reads a list of timestamps, calculates which files to remove and manages this list. Modified the Dockerfile to use this script specifically for css files cleanup, providing an solution without additional dependencies.

Disable HTTP GET method in nginx as requested.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.71%. Comparing base (243add0) to head (4da1489).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #935   +/-   ##
=======================================
  Coverage   31.71%   31.71%           
=======================================
  Files         175      175           
  Lines       20370    20370           
  Branches      548      548           
=======================================
  Hits         6461     6461           
  Misses      13909    13909           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Aldemylla Aldemylla merged commit 62f22a4 into main Dec 4, 2024
2 checks passed
@Aldemylla Aldemylla deleted the feature/keep-css branch December 4, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants