Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify port for telnet #106

Open
andrewtholt opened this issue Jul 8, 2022 · 3 comments
Open

Specify port for telnet #106

andrewtholt opened this issue Jul 8, 2022 · 3 comments

Comments

@andrewtholt
Copy link

I am connecting a serial adaptor to an esp8266, then using (linux) ser2net to I can telnet to the console. All good.

I can use socat to create a pty and then use mpfshell to connect to that. It's a bit messy though, and when you exit socat exits too

what would be useful would be (or something like):

mpfshell tn:192.123.0.43:2000

or

mpfshell tn:192.123.0.43,2000

I've stated looking at the code, but your opinion and suggestions would be appreciated.

Thanks,
Andrew

@skorokithakis
Copy link
Collaborator

Hm, this sounds like a useful thing to be able to do, but I'm afraid that I don't really remember much of the code at this point.

What's messy about socat? It seems like it would cleanly allow you to do this, and it'd be better to combine two utilities than overload mpfshell's functionality with something fairly orthogonal. That's not to say that I think the feature shouldn't be here, I'd just like to make sure it's necessary to be in the codebase first.

@andrewtholt
Copy link
Author

andrewtholt commented Jul 10, 2022 via email

@skorokithakis
Copy link
Collaborator

Hmm, yeah. I'm just afraid that some TCP/telnet stuff will eventually leak up into the code, so I'm wondering if it's worth it. If it's a small change (a few tens of LoC), I think it would be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants