Don't use auto in lambda functions #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is unsupported in gcc-4.8. while this is uglier to read it fixes compilation for older gcc versions that support c++1y, but not c++14. an example platform that is affected is amazon linux 1, which is used in aws lambda functions. therefore, this fix allows pysupercluster to be compiled and used in aws lambda functions.
|
Looks good to me, and tests pass so let's go |
|
@jlaine Thanks for the quick merge! Will you publish a release anytime soon? The reason I'm asking is that pip seems to have problems installing from requirements.txt from git sources, which I have to use to specifically install the master branch of this library. See also: pypa/pip#4390 pypa/pip#1833 (specifically the second issue described) |
|
Sure will do early next week. I'm thinking binary wheels built by CI would be nice too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that using auto in lambda functions is supported as of C++14, but not C++1y, which is used here.
This is also unsupported in gcc-4.8. While this is uglier to read it fixes compilation for older gcc versions that support c++1y, but not c++14.
An example platform that is affected is Amazon Linux 1, which is used in
AWS Lambda functions. Therefore, this fix allows pysupercluster to be
compiled and used in AWS Lambda functions.