Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for latest flake8 #79

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Fix for latest flake8 #79

merged 1 commit into from
Oct 15, 2019

Conversation

asottile
Copy link
Contributor

Resolves #76 - store_true + type doesn't make sense

Resolves #76 - `store_true` + `type` doesn't make sense
@coveralls
Copy link

coveralls commented Oct 15, 2019

Pull Request Test Coverage Report for Build 260

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.368%

Totals Coverage Status
Change from base Build 259: 0.0%
Covered Lines: 33
Relevant Lines: 34

💛 - Coveralls

@sobolevn
Copy link
Member

Oh, thanks a lot!

@sobolevn sobolevn merged commit 1d871ef into wemake-services:master Oct 15, 2019
@sobolevn
Copy link
Member

I will release it soon.

By the way, @asottile check out https://github.com/wemake-services/wemake-python-styleguide
I hope you will like it!

@asottile asottile deleted the patch-1 branch October 15, 2019 15:57
@asottile
Copy link
Contributor Author

ooh, they have the same bug -- I can fix it there too :D

@sobolevn
Copy link
Member

You are welcome 👍

@asottile
Copy link
Contributor Author

ah shoot it's a little trickier to fix there, I'll see what I can do though 🤔

sobolevn pushed a commit to wemake-services/wemake-python-styleguide that referenced this pull request Oct 15, 2019
`action='store_true'` + `type=None` is not valid for argparse

See also wemake-services/flake8-eradicate#79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when running via pre-commit
3 participants