-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task: Add versioning & release controls [WIP] #13
base: main
Are you sure you want to change the base?
Conversation
@skibinska @davidpmccormick would appreciate any thoughts on this approach if you have them! I'm going to think about the "unsolved issues" tomorrow, but if you have any thoughts on those in particular I'd love to hear them. |
@chriddell, I have two questions about testing steps:
|
|
…bel; ensures that version increments only occur on specific branch (token-studio)
This PR
...adds a skeleton of how we could approach versioning & releases for the package. It uses the changesets/action library from Atlassian.
The flow that this PR suggests is:
changeset.md
), which will contain a description of the changes made [1]main
containing all of the abovemain
Unsolved issues
[1] This PR doesn't contain a method for adding a custom description of the changes made. This should be possible - perhaps via the commit message we get from Token Studio Github Sync?
[2] This PR doesn't contain a method to control what kind of version (patch/minor/major) we release
Also, because all Token Studio changes will get pushed the same branch (
token-studio
), I think this could create issues with git conflicts, and a definite problem with naming collisions of the file we create at.changesets/changeset.md
.Testing
To test this, we need to:
token-studio