Use the builtin Terraform behaviour for updating Lambdas #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than doing our homebrew tainting of individual Lambdas, use the hash of the ZIP file and update the Lambda if it changes. It turns out this is indeed possible with Terraform, but it's somewhat obliquely documented: hashicorp/terraform#3825 This should resolve the issues with Lambda triggers being lost, because the Lambda is only updated, not deleted every time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR trying to achieve?
Rather than doing our homebrew tainting of individual Lambdas, use the hash of the ZIP file and update the Lambda if it changes. It turns out this is indeed possible with Terraform, but it's somewhat obliquely documented: hashicorp/terraform#3825
This should resolve the issues with Lambda triggers being lost, because the Lambda is only updated, not deleted every time.
Resolves #413.
Who is this change for?
Developers who don’t want unreliable infrastructure.
Have the following been considered/are they needed?
terraform apply.