Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple relation_embedder config from typesafe config #2793

Open
wants to merge 4 commits into
base: rk/transformer-event-from-flow
Choose a base branch
from

Conversation

kenoir
Copy link
Contributor

@kenoir kenoir commented Dec 19, 2024

What does this change?

This change implements a suggestion in a previous PR to have one place where we reference string based paths for typesafe config.

The suggestion is that services have classes that extend LambdaConfigurable and implement a build function that accepts typesafe config and provides a case class that extends ApplicationConfig.

How to test

  • Run the tests, do they pass?

How can we measure success?

Simpler and clearer implementation of new lambda services that consume typesafe config.

Have we considered potential risks?

This change should functionally be a no-op.

@kenoir kenoir marked this pull request as ready for review December 19, 2024 10:24
@kenoir kenoir requested a review from a team as a code owner December 19, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants