Decouple relation_embedder config from typesafe config #2793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This change implements a suggestion in a previous PR to have one place where we reference string based paths for typesafe config.
The suggestion is that services have classes that extend
LambdaConfigurable
and implement abuild
function that accepts typesafe config and provides a case class that extendsApplicationConfig
.How to test
How can we measure success?
Simpler and clearer implementation of new lambda services that consume typesafe config.
Have we considered potential risks?
This change should functionally be a no-op.