Fix: Batcher freeze #2260
Merged
Fix: Batcher freeze #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwlchan
reviewed
Nov 21, 2022
| # This var is read by the ingestor to switch the refresh interval off during a reindex | ||
| # It appears to be unnecessary, as the database copes well enough, so it is currently | ||
| # explicitly set to false, pending the removal of the switch. | ||
| # Was var.reindexing_state.scale_up_tasks |
There was a problem hiding this comment.
Awesome, glad to see we can remove this. The ticket is #2238
| # During a reindex, the batcher is expected to receive | ||
| # roughly 0.5 million messages in roughly 2 hours. | ||
| # At peak, messages appear at a rate of about 6000 per minute, so | ||
| # waiting for 20 minutes would perfectly align with processing 120000 at a time. |
There was a problem hiding this comment.
I have a vague memory that 120K is an SQS-imposed limit – can you link to some docs that confirm that?
alexwlchan
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #2255 (and #2256)