feat(CSI-295): add affinity for controller and separated nodeSelector for controller and node #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sergeyberezansky and the rest of your teammates on |
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (10/25/24)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
… for controller and node
sergeyberezansky
force-pushed
the
sergey/separate-affinity
branch
from
b65e6be to
b42fd0e
Compare
courtesy of The Openstack-Helm Authors
sergeyberezansky
added
the
enhancement
Graphite App
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added support for component-specific affinity and nodeSelector configurations in the CSI WekaFS plugin chart.
What changed?
affinityandnodeSelectorfields for both controller and node components._merge.tplfile with utility functions for merging configurations.How to test?
Why make this change?
This change provides more flexibility in deploying the WEKA CSI plugin. It allows users to define specific scheduling rules for controller and node components separately, which can be useful for optimizing resource allocation and meeting specific infrastructure requirements. The addition of the merge utility also improves the maintainability and extensibility of the chart.
Note regarding scheduling of components
Both controller and node components of the WEKA CSI plugin require connection to WEKA cluster, both via REST API and via data-plane (e.g. ability to mount WEKA filesystem) and require a WEKA client component on the particular node (or NFS configuration)