Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CSI-296): node registration fails after switch transport from NFS to Wekafs due to label conflict #375

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

sergeyberezansky
Copy link
Collaborator

@sergeyberezansky sergeyberezansky commented Oct 23, 2024

TL;DR

Added a node labeling step to the nodeserver daemonset initialization process.

What changed?

Modified the init container's command in the nodeserver daemonset to include a step that removes the topology.csi.weka.io/transport label from the node before fetching and storing the node metadata.

How to test?

  1. Deploy the updated chart with allowNfsFailback = true (without weka client installed on node)
  2. Verify that nodes are labeled with "topology.csi.weka.io/transport" set to "nfs"
  3. Ensure that the node has a running weka client and restart the node. The label should set to "wekafs"

Why make this change?

This change prepares nodes for potential topology-change operations in the CSI WekaFS plugin. Since CSI cannot modify existing labels upon node registration, having to remove the existing label prior to setting up a new one

Copy link

graphite-app bot commented Oct 23, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (10/23/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

@sergeyberezansky sergeyberezansky changed the base branch from sergey/fix-nfstargetips-override to graphite-base/375 October 23, 2024 13:45
@sergeyberezansky sergeyberezansky force-pushed the sergey/fix-reregister-switch-transport branch from 3ab09ad to 6c42144 Compare October 23, 2024 13:49
@sergeyberezansky sergeyberezansky changed the base branch from graphite-base/375 to dev October 23, 2024 13:50
@sergeyberezansky sergeyberezansky force-pushed the sergey/fix-reregister-switch-transport branch from 6c42144 to 156b3bc Compare October 23, 2024 13:50
@sergeyberezansky sergeyberezansky force-pushed the sergey/fix-reregister-switch-transport branch from 156b3bc to 624f719 Compare October 23, 2024 13:57
@sergeyberezansky sergeyberezansky merged commit 22940b1 into dev Oct 25, 2024
15 checks passed
@sergeyberezansky sergeyberezansky deleted the sergey/fix-reregister-switch-transport branch October 29, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant