Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CSI-289): add default nfs option for rdirplus #368

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

sergeyberezansky
Copy link
Collaborator

@sergeyberezansky sergeyberezansky commented Oct 14, 2024

TL;DR

Added "rdirplus" to default NFS mount options and simplified NFS mount option conversion.

What changed?

  • Added MountOptionNfsRdirPlus constant with value "rdirplus"
  • Included "rdirplus" in DefaultNfsMountOptions
  • Removed specific case handling for "inode_bits", "verbose", "quiet", and "obs_direct" options in the AsNfs() function

How to test?

  1. Verify that NFS mounts now include the "rdirplus" option by default
  2. Test NFS mount operations to ensure they work correctly with the new default options
  3. Confirm that removing specific case handling for certain options doesn't negatively impact NFS mount functionality

@graphite-app graphite-app bot requested a review from tigrawap October 14, 2024 16:53
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sergeyberezansky and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Oct 14, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (10/14/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

@sergeyberezansky sergeyberezansky merged commit 35c0016 into dev Oct 14, 2024
12 checks passed
@sergeyberezansky sergeyberezansky added the enhancement New feature or request label Oct 14, 2024 — with Graphite App
@sergeyberezansky sergeyberezansky deleted the sergey/rdirplus branch October 15, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant