-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CSI-252): implement kubelet PVC stats #322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (09/09/24)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
sergeyberezansky
force-pushed
the
sergey/node-vol-stats
branch
3 times, most recently
from
September 9, 2024 11:30
d15fd74
to
174c52d
Compare
sergeyberezansky
force-pushed
the
sergey/node-vol-stats
branch
from
September 11, 2024 08:00
174c52d
to
d44dc57
Compare
This was referenced Sep 11, 2024
Merged
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 11, 2024 10:12
966cdfd
to
df532ea
Compare
sergeyberezansky
force-pushed
the
sergey/node-vol-stats
branch
from
September 11, 2024 10:12
d44dc57
to
6c16465
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 11, 2024 11:12
df532ea
to
1ea1bd6
Compare
sergeyberezansky
force-pushed
the
sergey/node-vol-stats
branch
from
September 11, 2024 11:12
6c16465
to
aa86905
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 11, 2024 11:35
1ea1bd6
to
09cf230
Compare
sergeyberezansky
force-pushed
the
sergey/node-vol-stats
branch
from
September 11, 2024 11:35
aa86905
to
6f0de4e
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 11, 2024 11:52
09cf230
to
1e4001d
Compare
sergeyberezansky
force-pushed
the
sergey/node-vol-stats
branch
from
September 11, 2024 11:52
6f0de4e
to
39100a0
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 11, 2024 13:02
1e4001d
to
1278b06
Compare
sergeyberezansky
force-pushed
the
sergey/node-vol-stats
branch
from
September 11, 2024 13:02
39100a0
to
88e93f5
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 11, 2024 14:25
1278b06
to
502c178
Compare
sergeyberezansky
force-pushed
the
sergey/node-vol-stats
branch
2 times, most recently
from
September 12, 2024 09:40
20e1089
to
69f0a8b
Compare
Merge activity
|
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 12, 2024 12:00
502c178
to
f4d35ee
Compare
sergeyberezansky
force-pushed
the
sergey/node-vol-stats
branch
from
September 12, 2024 12:00
69f0a8b
to
8111d8a
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 12, 2024 12:45
f4d35ee
to
81afdbb
Compare
sergeyberezansky
force-pushed
the
sergey/node-vol-stats
branch
from
September 12, 2024 12:45
8111d8a
to
4974d45
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 12, 2024 12:48
81afdbb
to
cf521b3
Compare
sergeyberezansky
force-pushed
the
sergey/node-vol-stats
branch
from
September 12, 2024 12:49
4974d45
to
8ad9d7b
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 12, 2024 13:11
cf521b3
to
d369ae2
Compare
sergeyberezansky
force-pushed
the
sergey/node-vol-stats
branch
from
September 12, 2024 13:12
8ad9d7b
to
ca70a26
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 12, 2024 13:20
d369ae2
to
c3cae42
Compare
sergeyberezansky
force-pushed
the
sergey/node-vol-stats
branch
from
September 12, 2024 13:21
ca70a26
to
00e4f8a
Compare
sergeyberezansky
changed the base branch from
sergey/nfs-mounter-mapless
to
graphite-base/322
September 12, 2024 13:27
sergeyberezansky
force-pushed
the
sergey/node-vol-stats
branch
from
September 12, 2024 13:28
00e4f8a
to
5fe801f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Implemented NodeGetVolumeStats functionality and added new node service capabilities.
What changed?
NodeGetVolumeStats
method in theNodeServer
struct.getVolumeStats
helper function to fetch filesystem statistics.NewNodeServer
to include new node service capabilities:How to test?
NodeGetVolumeStats
method with the volume ID and path.Why make this change?
This change enhances the CSI driver's functionality by implementing volume statistics retrieval. It allows Kubernetes to query volume usage information, which is crucial for monitoring and managing storage resources. The added node service capabilities also improve the driver's feature set, making it more compliant with CSI specifications and providing better support for various storage operations.
Following this improvement, the following metrics become available for Weka CSI volumes: