Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CSI-243): service accounts for CSI plugin assume ImagePullSecret and cause error messages. #311

Merged
merged 1 commit into from
Sep 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
apiVersion: v1
kind: ServiceAccount
{{- if .Values.imagePullSecret}}
imagePullSecrets:
- name: {{ .Release.Name }}-creds
- name: {{ .Values.imagePullSecret }}
{{- end }}
metadata:
name: {{ .Release.Name }}-controller
namespace: {{ .Release.Namespace }}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
apiVersion: v1
kind: ServiceAccount
{{- if .Values.imagePullSecret}}
imagePullSecrets:
- name: {{ .Release.Name }}-creds
- name: {{ .Values.imagePullSecret }}
{{- end }}
metadata:
name: {{ .Release.Name }}-node
namespace: {{ .Release.Namespace }}
Expand Down
4 changes: 4 additions & 0 deletions charts/csi-wekafsplugin/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ images:
csidriver: quay.io/weka.io/csi-wekafs
# -- CSI driver tag
csidriverTag: *csiDriverVersion
# -- image pull secret required for image download. Must have permissions to access all images above.
# Should be used in case of private registry that requires authentication
imagePullSecret: ""

# -- Tolerations for all CSI driver components
globalPluginTolerations: &globalPluginTolerations
- key: node-role.kubernetes.io/master
Expand Down
Loading