Skip to content

Commit

Permalink
fix(deps): strip quotes from version string
Browse files Browse the repository at this point in the history
  • Loading branch information
sergeyberezansky committed Jan 19, 2025
1 parent 0e8c469 commit 5d5a427
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
release=${{ steps.auto_version.outputs.version }}
provenance: false # https://issues.redhat.com/browse/PROJQUAY-5013 quay doesn't support it
build-args: |
VERSION='${{ steps.auto_version.outputs.version }}'
VERSION=${{ steps.auto_version.outputs.version }}
platforms: linux/amd64,linux/arm64

# HELM
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/push-dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
quay.expires-after=14d
provenance: false # https://issues.redhat.com/browse/PROJQUAY-5013 quay doesn't support it
build-args: |
VERSION='${{ steps.auto_version.outputs.version }}'
VERSION=${{ steps.auto_version.outputs.version }}
platforms: linux/amd64,linux/arm64

# HELM
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -148,12 +148,12 @@ jobs:
cache-from: type=gha
cache-to: type=gha,mode=max
labels: |
revision='${{ steps.set_version.outputs.version }}'
revision=${{ steps.set_version.outputs.version }}
version=${{ steps.set_version.outputs.version }}
release=${{ steps.set_version.outputs.version }}
build-args: |
VERSION='${{ steps.set_version.outputs.version }}'
VERSION=${{ steps.set_version.outputs.version }}
platforms: linux/amd64,linux/arm64

- name: helm-docs
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ RUN true


RUN echo Building package
RUN CGO_ENABLED=0 GOOS=$TARGETOS GOARCH=$TARGETARCH go build -a -ldflags '-X main.version='$VERSION' -extldflags "-static"' -o "/bin/wekafsplugin" /src/cmd/*
RUN CGO_ENABLED=0 GOOS=$TARGETOS GOARCH=$TARGETARCH go build -a -ldflags "-X main.version=$VERSION -extldflags '-static'" -o "/bin/wekafsplugin" /src/cmd/*
FROM registry.k8s.io/kubernetes/kubectl:v${KUBECTL_VERSION} AS kubectl

FROM registry.access.redhat.com/ubi9/ubi:${UBI_HASH}
Expand Down
2 changes: 1 addition & 1 deletion tests/csi-sanity/ga-Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ RUN go install -v github.com/kubernetes-csi/csi-test/v5/cmd/[email protected]
COPY cmd cmd
COPY pkg pkg

RUN CGO_ENABLED=0 GOOS="linux" GOARCH="amd64" go build -a -ldflags '-X main.version='$VERSION' -extldflags "-static"' -o wekafsplugin ./cmd/wekafsplugin/main.go
RUN CGO_ENABLED=0 GOOS="linux" GOARCH="amd64" go build -a -ldflags "-X main.version=$VERSION -extldflags '-static'" -o wekafsplugin ./cmd/wekafsplugin/main.go


FROM golang:1.23-alpine
Expand Down

0 comments on commit 5d5a427

Please sign in to comment.