forked from bazelbuild/bazel
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix crash when a command-line aspect depends on a cycle.
PiperOrigin-RevId: 231246040
- Loading branch information
1 parent
9efd018
commit 30825c2
Showing
6 changed files
with
152 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| #!/bin/bash | ||
| # | ||
| # Copyright 2019 The Bazel Authors. All rights reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
||
| # --- begin runfiles.bash initialization --- | ||
| set -euo pipefail | ||
| if [[ ! -d "${RUNFILES_DIR:-/dev/null}" && ! -f "${RUNFILES_MANIFEST_FILE:-/dev/null}" ]]; then | ||
| if [[ -f "$0.runfiles_manifest" ]]; then | ||
| export RUNFILES_MANIFEST_FILE="$0.runfiles_manifest" | ||
| elif [[ -f "$0.runfiles/MANIFEST" ]]; then | ||
| export RUNFILES_MANIFEST_FILE="$0.runfiles/MANIFEST" | ||
| elif [[ -f "$0.runfiles/bazel_tools/tools/bash/runfiles/runfiles.bash" ]]; then | ||
| export RUNFILES_DIR="$0.runfiles" | ||
| fi | ||
| fi | ||
| if [[ -f "${RUNFILES_DIR:-/dev/null}/bazel_tools/tools/bash/runfiles/runfiles.bash" ]]; then | ||
| source "${RUNFILES_DIR}/bazel_tools/tools/bash/runfiles/runfiles.bash" | ||
| elif [[ -f "${RUNFILES_MANIFEST_FILE:-/dev/null}" ]]; then | ||
| source "$(grep -m1 "^bazel_tools/tools/bash/runfiles/runfiles.bash " \ | ||
| "$RUNFILES_MANIFEST_FILE" | cut -d ' ' -f 2-)" | ||
| else | ||
| echo >&2 "ERROR: cannot find @bazel_tools//tools/bash/runfiles:runfiles.bash" | ||
| exit 1 | ||
| fi | ||
| # --- end runfiles.bash initialization --- | ||
|
|
||
| source "$(rlocation "io_bazel/src/test/shell/integration_test_setup.sh")" \ | ||
| || { echo "integration_test_setup.sh not found!" >&2; exit 1; } | ||
|
|
||
| case "$(uname -s | tr [:upper:] [:lower:])" in | ||
| msys*|mingw*|cygwin*) | ||
| declare -r is_windows=true | ||
| ;; | ||
| *) | ||
| declare -r is_windows=false | ||
| ;; | ||
| esac | ||
|
|
||
| if "$is_windows"; then | ||
| export MSYS_NO_PATHCONV=1 | ||
| export MSYS2_ARG_CONV_EXCL="*" | ||
| declare -r EXE_EXT=".exe" | ||
| else | ||
| declare -r EXE_EXT="" | ||
| fi | ||
|
|
||
| # Tests in this file do not actually start a Python interpreter, but plug in a | ||
| # fake stub executable to serve as the "interpreter". | ||
|
|
||
| use_fake_python_runtimes_for_testsuite | ||
|
|
||
| #### TESTS ############################################################# | ||
|
|
||
| # Tests that a cycle reached via a command-line aspect does not crash. | ||
| # Does not crash deterministically, because if the configured target's cycle is | ||
| # reported first, the aspect loading key's cycle is suppressed. | ||
| function test_cycle_under_command_line_aspect() { | ||
| mkdir -p test | ||
| cat > test/aspect.bzl << 'EOF' || fail "Couldn't write aspect.bzl" | ||
| def _simple_aspect_impl(target, ctx): | ||
| return struct() | ||
| simple_aspect = aspect(implementation=_simple_aspect_impl) | ||
| EOF | ||
| echo "sh_library(name = 'cycletarget', deps = [':cycletarget'])" \ | ||
| > test/BUILD || fail "Couldn't write BUILD file" | ||
|
|
||
| # No flag, use the default from the rule. | ||
| bazel build --nobuild -k //test:cycletarget \ | ||
| --aspects 'test/aspect.bzl%simple_aspect' &> $TEST_log \ | ||
| && fail "Expected failure" | ||
| local readonly exit_code="$?" | ||
| [[ "$exit_code" == 1 ]] || fail "Unexpected exit code: $exit_code" | ||
| expect_log "cycle in dependency graph" | ||
| expect_log "//test:cycletarget \[self-edge\]" | ||
| expect_not_log "IllegalStateException" | ||
| } | ||
|
|
||
| run_suite "Tests for aspects" |