-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppLogo and AppHeader-title: provide for optional hyperlink #114
Comments
Rethinking: both AppLogo.vue and the
(though we would need styling or by default disable link styling in Component Style section). Another issue is that AppLogo.vue uses Vuetify v-avatar, allowing only square images and no links. So a rectangular image is squared/gets distorted. I'll issue an PR to also clarify. |
Maybe we should split this in separate issues. One regarding the title and one caring about a more flexible AppLogo component. So we do not mixup thing. In general: Do you see any advantage just to have a Vue component as HTML wrapper. For title this might make sense as we do in the Footer component. But for the AppLogo this could be done easily at application level instead of defining a HTML in the config. Maybe a hybrid approach would be cool here. Allowing to just provide an image URL in the config for easy usage (for non-tech people just configuring an app) would be nice and for advanced users providing a custom HTML is also allowed. Not sure how to differentiate between those. |
Yes makes sense. At first thought the issue was too trivial.
Well, the current PR has the hybrid approach, see AppLogo.vue there but it does not feel very elegant. But do you agree that the logo as This issue and the general app-development workflow with Wegue, plus some code I saw in a branch "App Folder Config": https://github.com/chrismayer/wegue/blob/app-fldr-conf/src/main.js#L47 made me think of a broader solution for Wegue (starter-)app development we can discuss via a new issue or on Gitter. I am happy to explain my proposals. |
Sure, happy to hear your ideas. |
In cases the
AppLogo
Wegue component implemented in AppLogo.vue should provide a hyperlink for when a user clicks the logo. This feature should be optional via a new AppLogo config attributelogoLink
.Possibly also the link target like
"_blank"
could be configured inlogoLinkTarget
.Also can be applied to the
title
(v-toolbar-title
) in the AppHeader implemented in AppHeader.vue: provide optional config fortitleLink
andtitleLinkTarget
.The text was updated successfully, but these errors were encountered: