Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppLogo and AppHeader-title: provide for optional hyperlink #114

Closed
justb4 opened this issue Mar 13, 2020 · 6 comments
Closed

AppLogo and AppHeader-title: provide for optional hyperlink #114

justb4 opened this issue Mar 13, 2020 · 6 comments

Comments

@justb4
Copy link
Collaborator

justb4 commented Mar 13, 2020

In cases the AppLogo Wegue component implemented in AppLogo.vue should provide a hyperlink for when a user clicks the logo. This feature should be optional via a new AppLogo config attribute logoLink.
Possibly also the link target like "_blank" could be configured in logoLinkTarget.

Also can be applied to the title (v-toolbar-title) in the AppHeader implemented in AppHeader.vue: provide optional config for titleLink and titleLinkTarget.

@justb4 justb4 changed the title AppLogo: provide for optional logo hyperlink AppLogo and AppHeader-title: provide for optional logo hyperlink Mar 13, 2020
@justb4 justb4 changed the title AppLogo and AppHeader-title: provide for optional logo hyperlink AppLogo and AppHeader-title: provide for optional hyperlink Mar 13, 2020
@justb4
Copy link
Collaborator Author

justb4 commented Mar 17, 2020

Rethinking: both AppLogo.vue and the title in AppHeader.vue could be made more flexible to configure if like AppFooter.vue regular HTML content would be allowed in the configuration. Like: in AppFooter.vue:

<span class="wgu-footer-left" v-html="footerTextLeft"></span>

AppHeader title could be simply:
<v-toolbar-title><span v-html="title"/></v-toolbar-title>. Adding a title with a link in the config:

  "title": "<a href='https://github.com/meggsimum/wegue' target='_blank' style='text-decoration: none; color: white'>Vue.js / OpenLayers WebGIS</a>",

(though we would need styling or by default disable link styling in Component Style section).

Another issue is that AppLogo.vue uses Vuetify v-avatar, allowing only square images and no links. So a rectangular image is squared/gets distorted.

I'll issue an PR to also clarify.

justb4 added a commit to Geolicious/wegue that referenced this issue Mar 17, 2020
@chrismayer
Copy link
Collaborator

chrismayer commented Mar 18, 2020

Maybe we should split this in separate issues. One regarding the title and one caring about a more flexible AppLogo component. So we do not mixup thing.

In general: Do you see any advantage just to have a Vue component as HTML wrapper. For title this might make sense as we do in the Footer component. But for the AppLogo this could be done easily at application level instead of defining a HTML in the config. Maybe a hybrid approach would be cool here. Allowing to just provide an image URL in the config for easy usage (for non-tech people just configuring an app) would be nice and for advanced users providing a custom HTML is also allowed. Not sure how to differentiate between those.

@justb4
Copy link
Collaborator Author

justb4 commented Mar 18, 2020

Maybe we should split this in separate issues. One regarding the title and one caring about a more flexible AppLogo component. So we do not mixup thing.

Yes makes sense. At first thought the issue was too trivial.

In general: Do you see any advantage just to have a Vue component as HTML wrapper. For title this might make sense as we do in the Footer component. But for the AppLogo this could be done easily at application level instead of defining a HTML in the config. Maybe a hybrid approach would be cool here. Allowing to just provide an image URL in the config for easy usage (for non-tech people just configuring an app) would be nice and for advanced users providing a custom HTML is also allowed. Not sure how to differentiate between those.

Well, the current PR has the hybrid approach, see AppLogo.vue there but it does not feel very elegant. But do you agree that the logo as v-avatar (square) is somewhat limiting?

This issue and the general app-development workflow with Wegue, plus some code I saw in a branch "App Folder Config": https://github.com/chrismayer/wegue/blob/app-fldr-conf/src/main.js#L47 made me think of a broader solution for Wegue (starter-)app development we can discuss via a new issue or on Gitter. I am happy to explain my proposals.

@chrismayer
Copy link
Collaborator

chrismayer commented Mar 19, 2020

But do you agree that the logo as v-avatar (square) is somewhat limiting?

Agree, I created #117 for that. Further discussions should be done there.

For the title improvement I also created a separate issue #118.

@chrismayer
Copy link
Collaborator

chrismayer commented Mar 19, 2020

This issue and the general app-development workflow with Wegue, plus some code I saw in a branch "App Folder Config": https://github.com/chrismayer/wegue/blob/app-fldr-conf/src/main.js#L47 made me think of a broader solution for Wegue (starter-)app development we can discuss via a new issue or on Gitter. I am happy to explain my proposals.

Sure, happy to hear your ideas.

@justb4
Copy link
Collaborator Author

justb4 commented Mar 19, 2020

Ok, so I close this issue as there is #117 and #118 . And will get back on Wegue app-development workflows.

@justb4 justb4 closed this as completed Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants