Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a plot_annotations method #813

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Create a plot_annotations method #813

merged 6 commits into from
Nov 8, 2024

Conversation

bw4sz
Copy link
Collaborator

@bw4sz bw4sz commented Oct 16, 2024

  • To help users create a more intuitive workflow add a plot_annotation methods.
  • Harden the utilities.read_file function

@bw4sz bw4sz requested a review from ethanwhite October 16, 2024 18:17
@henrykironde henrykironde mentioned this pull request Oct 21, 2024
@ethanwhite ethanwhite requested review from henrykironde and removed request for ethanwhite October 21, 2024 14:51
@ethanwhite
Copy link
Member

I'm pretty over-committed this week, so I'm going to ask @henrykironde and @bw4sz to go ahead and make whatever decisions/fixes you two think are best go ahead and merge without my further review. If you need me to look at it again it will need to be later next week.

Copy link
Contributor

@henrykironde henrykironde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some structures we can change but I will cover then when I am cleaning up the source. LGTM

@henrykironde henrykironde merged commit c86f96d into main Nov 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants