Fix attachment type (#175) #184
Conversation
tests/puppeteer-attachment.spec.ts
Outdated
| const mockedResUploadMedia = { | ||
| MediaId: 'MediaId', | ||
| } | ||
| const getExtName = (filename: string) => { |
There was a problem hiding this comment.
Why we re-define this function, instead of using the puppet.getExtName() for testing?
tests/puppeteer-attachment.spec.ts
Outdated
| const getExtName = (filename: string) => { | ||
| return extname(filename).slice(1) | ||
| } | ||
| const extToType = (ext: string): WebMessageType => { |
There was a problem hiding this comment.
Why we re-define this function, instead of using the puppet.extToType() for testing?
I think we should test those methods on the puppet, please remove the defines in the tests, and use the existing code in puppet instead.
This PR will be ready to be merged after we finished improving testing codes.
There was a problem hiding this comment.
OK,I just want to prevent extToType and getExtName from being accidentally modified
|
It is not a best practice for using I have pushed some modifications in this PR and has just been overwritten by your force push. |
Sorry, I am merging commits to make diff clearer. |
|
Thanks for your advice and help.
Probably puppet-wechat/src/puppet-wechat.ts Lines 1348 to 1352 in 1442099 |
|
Thank you very much for sending this PR for fixing the attachments sending bug! The code will be published on |
Fix #175
ref #178
Sorry about that, #178 cannot be opened again.