Fix x64 no expected browser bug #79
Conversation
bin/matrix-appservice-wechaty.ts
Outdated
| @@ -12,6 +12,13 @@ async function main () { | |||
| log.level(process.env.LOG_LEVEL as any) | |||
| } | |||
|
|
|||
| if (process.env.SIMULATED) { | |||
There was a problem hiding this comment.
Where does this SIMULATED variable comes from?
.gitignore
Outdated
| @@ -61,6 +61,7 @@ t/ | |||
| /dist/ | |||
|
|
|||
| *.memory-card.json | |||
| config/config.yaml | |||
There was a problem hiding this comment.
Could you please explain why you add this ignore, what's the problem if we does not include it?
There was a problem hiding this comment.
It's a config file for run this project(genarate the registration file or run bridge), containing some personal setting.
bin/matrix-appservice-wechaty.ts
Outdated
| @@ -12,6 +12,13 @@ async function main () { | |||
| log.level(process.env.LOG_LEVEL as any) | |||
| } | |||
|
|
|||
| if (process.env.SIMULATED) { | |||
| // XXX This is aim to use the chrome referred by /usr/bin/chromium-browser as dependency of wechaty.node_modules.puppeteer module. | |||
| Object.defineProperty(process, 'arch', { | |||
There was a problem hiding this comment.
I don't think it's a good idea to modify process.arch in our code.
It looks like a workaround and we should find a solution instead.
|
Instead of closing a PR, we should keep it open and continue improving it by pushing new commits. |
…ble named WECHATY_PUPPET_PUPPETEER_ENDPOINT
There was a problem hiding this comment.
Because wechaty-puppet-wechat have not supported users to set chrome/chromium path with environment variable now, I add some code in src/wechaty-manager.ts.
|
Good to see you using the However, I believe this support would be better to be added to https://github.com/wechaty/wechaty-puppet-wechat/blob/6975f402960f0af34f8a39341444228a31a97594/src/puppet-wechat.ts#L123-L130 because there is the right place to handle this feature. It would be great if you can move this change to the above |
#78