Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add puppet schemas and add user_link #9

Merged
merged 2 commits into from
Apr 3, 2020
Merged

add puppet schemas and add user_link #9

merged 2 commits into from
Apr 3, 2020

Conversation

SilkageNet
Copy link
Contributor

  1. add puppet schemas
  2. add user_link

@huan huan requested a review from dingdayu April 3, 2020 07:30
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is great! LGTM

@huan
Copy link
Member

huan commented Apr 3, 2020

Thank you very much for your contribution, your code translation would be greatly helpful for our Go Wechaty code base with a huge code line of improvement!

I'd like to invite @dingdayu to have a look at your PR and to see if he has any comments because we are just talking about the naming styles for the enums in Go (see #6)

And it's our great pleasure to have you onboard, welcome!

@huan
Copy link
Member

huan commented Apr 3, 2020

Please accept my invitation from our Wechaty organization on GitHub so that you can become our contributor team members:

You've invited Silkage to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation.

Thanks!

Copy link
Member

@dingdayu dingdayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, The code is great.

src/wechaty-puppet/schemas/image.go Show resolved Hide resolved
@SilkageNet SilkageNet requested review from dingdayu and huan April 3, 2020 08:20
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan huan merged commit ab6191f into wechaty:master Apr 3, 2020
@huan
Copy link
Member

huan commented Apr 3, 2020

Cheers, welcome our 2nd Go Wechaty contributor @SilkageNet !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants