add default type text/javascript of none is defined (#34)

webworkerJoshua · Mar 26, 2024 · 5f11bea · 5f11bea
1 parent c4dfb30
commit 5f11bea
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Changelog of PrivacyWire
 
+## 1.1.6
+- add default type `text/javascript` if no `data-type` is defined. https://github.com/webworkerJoshua/privacywire/issues/33
+
 ## 1.1.5
 
 - Trigger CustomEvents when banner and options are opened/closed by @teppokoivula in https://github.com/webworkerJoshua/privacywire/pull/32

diff --git a/PrivacyWire.module b/PrivacyWire.module
@@ -31,7 +31,7 @@ class PrivacyWire extends WireData implements Module, ConfigurableModule
             'summary' => "This module adds management options for GDPR-relevant elements (loading maps, videos etc. only after accepting external media) and cookies.",
             'author' => "blaueQuelle",
             'href' => "https://github.com/blaueQuelle/privacywire",
-            'version' => "1.1.5",
+            'version' => "1.1.6",
             'autoload' => true,
             'singular' => true,
             'requires' => ["PHP>=7.2", "ProcessWire>=3.0.110"],

diff --git a/src/js/PrivacyWire.js b/src/js/PrivacyWire.js
@@ -421,7 +421,7 @@ class PrivacyWire {
 
     updateAllowedElementOther(el) {
         const {dataset} = el
-        el.type = dataset.type
+        el.type = dataset.type ?? 'text/javascript'
         el.src = dataset.src
         el.srcset = dataset.srcset
         this.removeUnusedAttributesFromElement(el)