Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename App.js -> app.js #882

Merged
merged 1 commit into from
Sep 3, 2016
Merged

Rename App.js -> app.js #882

merged 1 commit into from
Sep 3, 2016

Conversation

mathiasvr
Copy link
Contributor

@mathiasvr mathiasvr commented Sep 3, 2016

Fixes #875.

This issue was introduced in #863 because of renaming a require path, but not the file.
This is not a problem on Mac (and Windows?) since the filesystem is case-insensitive, and probably why it went undetected.

@dcposch
Copy link
Contributor

dcposch commented Sep 3, 2016

LGTM. I thought we lowercased all the file names earlier... guess not. My bad.

@dcposch dcposch merged commit 704455c into master Sep 3, 2016
@bnjmnt4n bnjmnt4n deleted the m/fix-875 branch September 4, 2016 02:32
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants