Pref: default torrent file handler

[dcposch]

Before, the app made itself the default torrent file handler automatically, pissing off some of our users. Now, it's not by default, and you can change it in the prefs.

Fixes #367

[dcposch]

@feross @diimdeep @mathiasvr

[dcposch]

[feross]

Should use setStateValue to match the other place it's used. Or, better just get rid of that function and call dispatch('updatePreferences', ...) directly everywhere.

[feross]

LGTM 👍

[mathiasvr]

I think the program should initially associate with the .torrent extension but not make itself the default handler, that should be up to the user through the OS. For magnet links I would add a button that makes WebTorrent the default handler when clicked and not every time it is started.

[feross]

@mathiasvr The menu label is misleading. This preference affects both .torrent and magnet handling.

On macOS, the .torrent association is automatic (defined in Info.plist). So if there's no other handler, WebTorrent will be default. If there's another default, then the user can still use "Open With..." to select WebTorrent.

On Windows / Linux, the current situation (after this PR) is that WebTorrent does nothing until the preference is toggled. This is not ideal -- thanks for pointing this out.

With this change, now the .desktop file will not get installed on Linux systems until the user toggles the preference option. But that file is needed for the app icon to show up correctly in the Unity launcher, and to support pinning etc.

I think we need to change handlers.js to distinguish between installing handlers and making WebTorrent the default.

• install: associate with .torrent (but not as the default program), i.e. install .desktop file (linux), add to registry (windows)
• makeDefault: become default .torrent handler, register magnet handler (there can only be one)
• removeDefault: give up .torrent handler, unregister magnet handler
• uninstall: only used by the Windows program uninstaller to completely clean up registry entries, never called on Mac or Linux

@dcposch Does that seem reasonable to you?

[feross]

Let's move discussion to this new issue: #773

(Don't want to lose track of it by discussing in this closed PR.)

[feross]

Released in WebTorrent Desktop v0.11!