Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error when media format is unsupported #409

Merged
merged 4 commits into from
Apr 14, 2016
Merged

Show error when media format is unsupported #409

merged 4 commits into from
Apr 14, 2016

Conversation

feross
Copy link
Member

@feross feross commented Apr 14, 2016

Before this change, the player would just get stuck on the loading
screen forever without notifying the user.

feross added 4 commits April 14, 2016 15:25
Before this change, the player would just get stuck on the loading
screen forever without notifying the user.
@feross feross merged commit efd0a1a into master Apr 14, 2016
@feross feross deleted the f/error branch April 14, 2016 22:30
mathiasvr pushed a commit to mathiasvr/webtorrent-desktop that referenced this pull request May 26, 2016
* fix error about pop

* location-history: add optional callbacks

* set handler on first tick

discovered by @dcposch

* Show error when media format is unsupported

Before this change, the player would just get stuck on the loading
screen forever without notifying the user.
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant