Add YouTube style hotkeys. Closes #1395

[dsernst]

This is a continuation of PR #1443, which appears abandoned.

Props to @hicom150 for starting that. I would have added commits on top of that, to preserve git history etc, but the underlying branch looks deleted 😕

This PR takes into account the code changes requested by @mathiasvr in #1443 (comment)

I would request the following changes:

• use keydown instead of keyup, i think instant feedback and repeated events is an improvement.
• use window.addEventListener instead of document.addEventListener.
• use e.key instead e.code, currently this PR only works with qwerty keyboard layouts.

All of these have been included.

👍 This PR has been tested to work locally on macOS 10.14.4.

---

This closes the original feature request by @feross in #1395.

[dsernst]

There was also discussion in that PR about taking a different approach: replacing the existing hotkeys (in Menu > Playback) instead of adding these new ones

So I also made a branch to take this other approach:

master...dsernst:playback-hotkeys

👍 This commit was tested to work locally on macOS 10.14.4.

---

Happy to send this in as a PR instead.
I have no strong preference either way — I only want to use the new hotkeys.

Hope this won't create a bikeshed... 🙃

[Borewit]

Thanks a lot for picking up this effort and the hard work @dsernst!

I think it is about time to deliver this YouTube shortcuts to the user.

I don't use the shortcuts to ofton, so I am not the best user to test, but it looks good to me, shortcuts seem to work.

[mathiasvr]

Thanks for picking this up and addressing all my annoying comments! 😄

I still prefer the solution on your second branch with youtube style shortcuts only.
I think the menu looks cleaner and allows new users to quickly learn the IMO preferred shortcuts.

However, to avoid more stalling I will accept this and let another person decide whether to merge this or the other (better) option. 😏

[alxhotel]

Looks great. I'm just missing the key F to go fullscreen :)

[dsernst]

@alxhotel:
Looks great. I'm just missing the key F to go fullscreen :)

Added (07816f7). Works on local macOS 10.14.4 testing.

[dsernst]

@mathiasvr:

Thanks for picking this up and addressing all my annoying comments! 😄

I still prefer the solution on your second branch with youtube style shortcuts only.
I think the menu looks cleaner and allows new users to quickly learn the IMO preferred shortcuts.

However, to avoid more stalling I will accept this and let another person decide whether to merge this or the other (better) option. 😏

Yes, I can see pros & cons each way.

My recommendation for productive forward momentum (similar to your PR approval) is to merge these in as additional hotkeys for now, so they can immediately start being used, albeit undocumented.

And then I will make a new PR (like master...dsernst:playback-hotkeys), to sort out whether to remove the old hotkeys and show these new ones in the Menus. That seems like a bit more of a drawn out conversation, but doesn't need to block getting these new ones in.

[Borewit]

Let's indeed keep the ball roling guys.