Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins #1125

Closed
wants to merge 12 commits into from
Closed

Plugins #1125

wants to merge 12 commits into from

Conversation

codealchemist
Copy link
Contributor

I'd love some feedback on this one.
If we want to support plugins this might be a good start.
I already have the first working plugin too:
https://github.com/codealchemist/webtorrent-transparent

You can test it by adding it to WebTorrent Desktop config like this:

  "plugins": {
    "webtorrent-transparent": "codealchemist/webtorrent-transparent"
  }

Hope we can make progress in this direction :)
Cheers!

@talarari
Copy link

what's the status on this? is plugin support being worked on?

@codealchemist
Copy link
Contributor Author

@talarari I provided something like an MVP / working prototype on the plugins system based on Zeit's Hyper.
This includes our first plugin, useful to test the plugins system.
I was waiting for feedback about this and some help to polish it.

Thanks for your interest!

This will enable plugins to dispatch events and interact with the
renderer process; removed unused extension keys.
Dispatcher now sends params to plugins; notifying about plugin load
errors; allowing local plugin paths not to end with a slash.
@codealchemist codealchemist requested review from Flet and removed request for grunjol September 26, 2017 17:13
@stale
Copy link

stale bot commented May 10, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label May 10, 2018
@stale stale bot closed this May 17, 2018
@feross feross reopened this May 20, 2018
@stale stale bot removed the stale label May 20, 2018
@hicom150 hicom150 mentioned this pull request Sep 18, 2019
@codealchemist
Copy link
Contributor Author

@DiegoRBaquero maybe we can close this one too.
It's been a long time since anyone pushed for plugins and if we ever decide we want it it might be better to start from scratch.
Cheers!

@DiegoRBaquero
Copy link
Member

@DiegoRBaquero maybe we can close this one too.
It's been a long time since anyone pushed for plugins and if we ever decide we want it it might be better to start from scratch.
Cheers!

understood, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants