Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dragging magnet links #284

Closed
RaeesBhatti opened this issue Apr 3, 2016 · 7 comments
Closed

Allow dragging magnet links #284

RaeesBhatti opened this issue Apr 3, 2016 · 7 comments
Assignees
Milestone

Comments

@RaeesBhatti
Copy link

It would be handy to have the app accept dragging of torrent links instead of doing a manual copy-paste.

@RaeesBhatti
Copy link
Author

Maybe need to make some changes here in the drag-drop package.

@dcposch
Copy link
Contributor

dcposch commented Apr 3, 2016

Looked into it. This would require making drag-drop a lot fancier / more complicated or writing our own drag drop handler.

@holmesworcester
Copy link

holmesworcester commented Apr 30, 2016

It might be worth changing the text to say "Drop a torrent here or paste a magnet link (sorry, dragging magnet links won't work)"

Right now the language is technically clear, but I assumed it was possible to drag a magnet link, and it seemed like the app was simply broken when that didn't work.

A form field would be the standard way of allowing somebody to paste a magnet link. Then it would be very clear you were asking them to paste it.

@codealchemist
Copy link
Contributor

I've added a PR on drag-drop which adds support to drop magnet links.
feross/drag-drop#25

@feross
Copy link
Member

feross commented Aug 4, 2016

Thanks for the PRs to drag-drop, @mathiasvr and @codealchemist ! I think this should be straightforward to implement in WebTorrent Desktop now 👍

@feross feross self-assigned this Aug 4, 2016
@feross
Copy link
Member

feross commented Aug 4, 2016

Sent a PR that implements this: #758

Review and testing welcome! 👍

@codealchemist
Copy link
Contributor

Awesome! Thanks @feross!
Already added comments on the PR :)

@feross feross closed this as completed in 6740921 Aug 4, 2016
feross added a commit that referenced this issue Aug 4, 2016
Allow dragging magnet links (Fix #284)
@feross feross modified the milestones: v0.10, v1.0 Aug 5, 2016
@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants