Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the music metadata reading and updating mechanism #1340

Closed
1 task done
Borewit opened this issue Mar 10, 2018 · 3 comments
Closed
1 task done

Improve the music metadata reading and updating mechanism #1340

Borewit opened this issue Mar 10, 2018 · 3 comments
Assignees
@Borewit
Labels
enhancement meta

Comments

@Borewit
Copy link
Member

Borewit commented Mar 10, 2018 •
edited
Loading

Improve the way metadata is read during the torrent life cycle, starting with a partial download to a completed file.

Related:

Retrieve metadata asynchronous bit by bit, as data flows in.
@Borewit Borewit mentioned this issue Mar 10, 2018
Merged
@Borewit Borewit mentioned this issue Mar 20, 2018
Closed
@Borewit Borewit mentioned this issue Apr 27, 2018
Merged
@codealchemist
Copy link
Contributor

Maybe we can close this after #1361?
What do you think @Borewit ?

@Borewit
Copy link
Member Author

Borewit commented May 2, 2018

I think there is still room for improvement. One the things we can do is use the embedded album art (if that is available in a suitable resolution) of the current played song.

@Borewit Borewit mentioned this issue Jul 25, 2018
Merged
@Borewit Borewit mentioned this issue Aug 2, 2018
Merged
3 tasks
@Borewit Borewit self-assigned this Aug 13, 2018
@Borewit Borewit mentioned this issue Aug 13, 2018
Merged
4 tasks
mathiasvr pushed a commit that referenced this issue Sep 26, 2018
@Borewit @mathiasvr
Asynchronous music-metadata updates while streaming (#1449)
06566d3 
* Ensure that default file/protocol handlers are re-installed after updating.

Previously, they were only installed when the preference was changed.
This caused the handlers to point to non-existing files after updates
occurred and older versions were removed by Squirrel.

Closes #791, #911.

* #1340: Switch to async metadata updates.

* Use fat arrow

* Fix issue track number not displayed if total number of tracks is not defined (common.track.of === null).

* Add disk number in addition to track number.

* Update order of audio properties from: album, track, disk, format to track, disk, album, format

* #1340 Update music-metadata to 2.5.0, enabling async 'per' tag updates
#1452 Fix for playing some '.m4b' files

* #1340 Commented out the metadata event debug output.

* #1340 Remove line comment to get rid of max line length lint error

* Update music-metadata 2.6.0 to fix some async events are getting triggered.

* Return JSX block.

* Get rid of third parameter which is replaced by CSS capitalize

* Fixed error when value is undefined.

* Update music-metadata dependency to 2.6.1.

* fix(package): update music-metadata to version 3.1.0

Closes #1478

* Revert "Ensure that default file/protocol handlers are re-installed after updating."

This reverts commit 39145b2.
@Borewit
Copy link
Member Author

Borewit commented Sep 27, 2018

I consider this work as done with PR #1449 merged into the master branch.

@Borewit Borewit closed this as completed Sep 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Borewit Borewit

Labels
enhancement meta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codealchemist @Borewit