Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player page: Formatting issue in the speed stats #1039

Closed
feross opened this issue Oct 13, 2016 · 1 comment
Closed

Player page: Formatting issue in the speed stats #1039

feross opened this issue Oct 13, 2016 · 1 comment
Labels
bug good first contribution help wanted

Comments

@feross
Copy link
Member

feross commented Oct 13, 2016

What version of WebTorrent Desktop? 0.17.2

What operating system and version? All

What did you do? Start a transfer.

What did you expect to happen? Speed should be nicely spaced out.

What actually happened?

screen shot 2016-10-12 at 8 46 15 pm

There's a random comma after the word "downloaded" and the upload/download are not spaced correctly.
babruix added a commit to babruix/webtorrent-desktop that referenced this issue Oct 13, 2016
@babruix
webtorrent#1039: Formatting fixed.
3f54124 
Removed comma and added space after download speed.
babruix added a commit to babruix/webtorrent-desktop that referenced this issue Oct 13, 2016
@babruix
webtorrent#1039: Formatting fixed.
7a6321f 
Removed comma and added space after download speed.
feross pushed a commit that referenced this issue Oct 14, 2016
@babruix @feross
#1039: Formatting fixed.
32f96c0 
Removed comma and added space after download speed.
@feross
Copy link
Member Author

feross commented Oct 14, 2016

Fixed by #1039

@feross feross closed this as completed Oct 14, 2016
@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug good first contribution help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@feross