Merge pull request #1737 from akaustav/fix-about-window

Fix: Increase height of 'About' window
webtorrent · Nov 26, 2019 · 82f8732 · 82f8732
2 parents 93b0e42 + 2b8fa8b
commit 82f8732
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/main/windows/about.js b/src/main/windows/about.js
@@ -15,7 +15,7 @@ function init () {
     backgroundColor: '#ECECEC',
     center: true,
     fullscreen: false,
-    height: 170,
+    height: 250,
     icon: getIconPath(),
     maximizable: false,
     minimizable: false,
@@ -33,11 +33,12 @@ function init () {
 
   win.loadURL(config.WINDOW_ABOUT)
 
-  // No menu on the About window
-  win.setMenu(null)
-
   win.once('ready-to-show', function () {
     win.show()
+    // No menu on the About window
+    // Hack: BrowserWindow removeMenu method not working on electron@7
+    // https://github.com/electron/electron/issues/21088
+    win.setMenuBarVisibility(false)
   })
 
   win.once('closed', function () {

diff --git a/static/about.html b/static/about.html
@@ -34,6 +34,6 @@ <h1>WebTorrent</h1>
       (<script>document.write(require('webtorrent/package.json').version)</script>)
       (<script>document.write(process.arch === 'x64' ? '64-bit' : '32-bit')</script>)
     </p>
-    <p><script>document.write(require('../config').APP_COPYRIGHT)</script></p>
+    <p><script>document.write(require('../build/config').APP_COPYRIGHT)</script></p>
   </body>
 </html>