Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML Compression removes <!DOCTYPE html> #299

Closed
scherii opened this issue Sep 1, 2014 · 5 comments
Closed

HTML Compression removes <!DOCTYPE html> #299

scherii opened this issue Sep 1, 2014 · 5 comments
Assignees
@jaswrks
Labels
bug pro
Milestone
v141001

Comments

@scherii
Copy link

scherii commented Sep 1, 2014

If I select Yes, compress (remove extra whitespace) in the final HTML code too. the compressor removes the .

It seems like this bug was added recently (it didn't remove the doctype in earlier versions).

Tested with WordPress 3.9.2 and Quick Cache Pro 140829.
@jaswrks jaswrks mentioned this issue Sep 1, 2014
Closed
@jaswrks
Copy link

jaswrks commented Sep 1, 2014

Thanks for the report! Confirmed, this bug exists in the latest release.
Related somewhat to: #295 Tracking progress on this issue in the HTML Compressor repo. See: wpsharks/html-compressor#39

We will also update this issue once the problem has been corrected for QCP too.

@jaswrks jaswrks mentioned this issue Sep 1, 2014
Closed
@jaswrks jaswrks self-assigned this Sep 1, 2014
@jaswrks
Copy link

jaswrks commented Sep 1, 2014

This has been fixed in the HTML Compressor (dev branch).
The next release of QCP will likely include this fix. Further updates will follow.

@raamdev
Copy link
Contributor

raamdev commented Sep 2, 2014

@jaswsinc Thanks so much for fixing this.

@scherii Thanks for the bug report! A fix will go out with the next release.

@raamdev
Copy link
Contributor

raamdev commented Sep 2, 2014

Next release changelog:

  • Bug Fix (Pro): Fixed a bug where the HTML Compressor, when enabled with the "remove extra whitespace in the final HTML" option, would incorrectly remove <!DOCTYPE html>. See #299.

@raamdev raamdev closed this as completed Sep 2, 2014
@raamdev raamdev added this to the Next Release milestone Sep 2, 2014
@scherii
Copy link
Author

scherii commented Sep 2, 2014

Thank you guys! :)

@jaswrks jaswrks mentioned this issue Sep 8, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaswrks jaswrks

Labels
bug pro
Projects
None yet
Milestone
v141001
Development

No branches or pull requests
3 participants
@raamdev @scherii @jaswrks