-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3rd Party Plugin Compatibility: AMP #688
Comments
+5 |
We may also need to look at how permalinks are structured when this plugin is running, because we need to know if pagination occurs like |
It appears that Comments, Pages, and Archives are not supported at all yet by the AMP plugin. The comments section and any links to comments do not appear on posts that are loaded via AMP. The only other thing to note is that you can also load the AMP version of a post by appending |
@jaswsinc FYI, I tested and confirmed the fix you noted above. It works great! Cache files for AMP versions of posts are now automatically cleared when a post cache needs to be cleared. :-) I've submitted a PR that I will be merging soon. |
Cool. That's awesome! |
Next Release Changelog:
|
Comet Cache v160227 has been released and includes changes from this GitHub Issue. See the v160227 announcement for further details. This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#688). |
The AMP plugin adds support for the Accelerated Mobile Pages (AMP) Project. AMP is already used by Google and is becoming a big thing. The AMP WordPress plugin (developed by Automattic) already has 10k+ active installs.
Initial testing with Comet Cache v160223.1 indicates that AMP pages (which are generated by appending
/amp/
to the URL, e.g., for/example-post/
you simply access/example-post/amp/
to get the AMP version) are cached fine by Comet Cache, resulting in a cache file stored in[...]/example-post/amp.html
.However, what is not working is the automatic clearing of the AMP cache file when the post changes. So if we edit the Example Post, Comet Cache clears the cache file for
/example-post/
but does not clear the cache file for/example-post/amp/
. We need to update Comet Cache to add support for the AMP plugin.The text was updated successfully, but these errors were encountered: