Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont attempt to overwrite RTCSessionDescription.sdp #1071

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

fippo
Copy link
Member

@fippo fippo commented Mar 10, 2021

follow-up on #1042. Shouldn't be necessary in new Safari versions but see here

@fippo fippo force-pushed the safari-rtcsessiondescription-readonly branch from 6a62de1 to de0348c Compare March 10, 2021 10:02
Copy link
Collaborator

@dagingaa dagingaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fippo fippo merged commit de097ee into master Mar 10, 2021
@fippo fippo deleted the safari-rtcsessiondescription-readonly branch March 10, 2021 15:11
@fippo fippo mentioned this pull request Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants