Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ACLJs to use *, SURT wildcard to match all URLs #882

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

tw4l
Copy link
Member

@tw4l tw4l commented Feb 13, 2024

Fixes #881

Description

This PR adds the option to use *, as a SURT in ACLJ files to match any URL. This builds off of the existing ability to do this per-TLD, e.g. com,.

The PR also adds a passing test for the use case described in the issue (overriding default_access: block to all URLs for a specific user), and documents the new option.

Motivation and Context

This allows administrators to give access to all resources to specific (e.g. staff) users.

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed

@tw4l tw4l requested a review from ikreymer February 13, 2024 17:56
@tw4l tw4l force-pushed the issue-881-acl-all-tlds-wildcard branch from 42a2916 to 7c5fa48 Compare April 2, 2024 21:18
Copy link
Member

@ikreymer ikreymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good, only thought is if its worth mentioning that the *, rule should generally be last, which works out well since it sorts correctly and would be before any valid domain.

@tw4l tw4l merged commit 86ee3bd into main Apr 3, 2024
10 checks passed
@tw4l tw4l deleted the issue-881-acl-all-tlds-wildcard branch April 3, 2024 21:12
@Quirinus
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for catch-all wildcard *, in ACLs
3 participants