Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass env vars to tox #823

Merged
merged 1 commit into from
Mar 26, 2023
Merged

Pass env vars to tox #823

merged 1 commit into from
Mar 26, 2023

Conversation

tw4l
Copy link
Member

@tw4l tw4l commented Mar 1, 2023

Description

This enables us to skip youtube-dl tests in GitHub Actions by ensuring that the "CI" env var is passed to tox.

Motivation and Context

Test test_live_video_loader is failing in CI when it should be skipped.

See: https://github.com/webrecorder/pywb/actions/runs/4290394517/jobs/7509706519#step:5:914

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

This enables us to skip youtube-dl tests in GitHub Actions by
ensuring that the "CI" env var is passed to tox.
@tw4l tw4l marked this pull request as ready for review March 1, 2023 18:10
@tw4l tw4l requested a review from ikreymer March 1, 2023 18:10
@tw4l tw4l merged commit ed36830 into main Mar 26, 2023
@tw4l tw4l deleted the dev/skip-youtube-dl-test-in-ci branch March 26, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant