Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#804] Use default_locale when lang not set in the request #805

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

krakan
Copy link
Contributor

@krakan krakan commented Jan 31, 2023

Before a language is selected in a Pywb session it's expected that the default_locale from the config-file would be used. This works most of the time but not for eg. formatting dates on the query.html page where instead the en locale is used.

Description

Let the FrontEndApp __init__ method set a default_locale attribute as defined in the config file and use that as the default for incoming requests.

Motivation and Context

See issue #804.

Screenshots (if appropriate):

See issue #804.

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

@tw4l
Copy link
Member

tw4l commented Jan 31, 2023

Thanks for this @krakan ! :)

@tw4l tw4l merged commit d392a8d into webrecorder:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants